Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimizer moved to a separate repo #628

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

platonfloria
Copy link
Collaborator

@platonfloria platonfloria commented May 7, 2024

NOTE: #610 AND #611 HAS BEEN MERGED

This branch is freezing the Optimizer API in anticipation of the move into the new repo and the more arms length relationship between the optimizer code and the bot code

The major API changes effectuated are the following

  • the CPCContainer object has been renamed to CurveContainer; whilst the old name is still legal it will be removed very soon and should be changed everywhere now
  • the signature of the alternative constructors CPC.from_xxx has slightly changed;
    • for most of them the only change was to enforce keyword rather than positional arguments for most of the arguments to avoid mistakes
    • for from_univ2 we changed the names of the liquidity arguments to liq_tknb and liq_tknq
  • the signature of the MargPOptimizer.optimize() function has changed:
    • pstart is now an argument, not part of the paramter dict (for the time being you are still allowed to supply it in the parameter dict but this will be removed soon)
    • there is a mode argument that can be MO_MODE_ABS or MO_MODE_REL that replaces params["crit"] (the latter is already illegal)
    • some of the constants and parameters have been renamed (MOXXX -> MO_XXX; also eps -> epsr and epsjac -> jach)

sklbancor
sklbancor previously approved these changes May 7, 2024
@sklbancor sklbancor mentioned this pull request May 7, 2024
@platonfloria platonfloria force-pushed the optimizer-api-2 branch 3 times, most recently from e0fdff3 to 3a97507 Compare May 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants