Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription.DonationItems is not used and can be removed #787

Open
tiagonmas opened this issue Dec 10, 2024 · 2 comments
Open

Subscription.DonationItems is not used and can be removed #787

tiagonmas opened this issue Dec 10, 2024 · 2 comments
Assignees
@guerrerotook
Labels
PendingProductionTesting prio:Low issues with lower priority

Comments

@tiagonmas
Copy link
Collaborator

Describe the bug
All items are null. Not sure what's the purpose of this field.
Can we remove it @guerrerotook

select DonationItems, count(1) from Subscriptions
group by DonationItems

DonationItems	Total
NULL	351
@tiagonmas tiagonmas added the prio:Low issues with lower priority label Dec 10, 2024
@guerrerotook
Copy link
Contributor

You are right because the donation items are coming from the first donation make.

@guerrerotook
Copy link
Contributor

Removed in a EF Migration

guerrerotook added a commit that referenced this issue Dec 14, 2024
@guerrerotook
Remove the DonationItems property from the subscription class. #787
5d0bd81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guerrerotook guerrerotook

Labels
PendingProductionTesting prio:Low issues with lower priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiagonmas @guerrerotook