Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription expiration is set for 1 year and not 5 #675

Closed
tiagonmas opened this issue Jul 18, 2022 · 12 comments
Closed

Subscription expiration is set for 1 year and not 5 #675

tiagonmas opened this issue Jul 18, 2022 · 12 comments
Assignees
@guerrerotook
Labels
bug Something isn't working prio:High Issue of higher priority. Should be addressed first

Comments

@tiagonmas
Copy link
Collaborator

Describe the bug
When we create a subscription the expire date is set for 1 year, but the code is set for 5

image

image
@tiagonmas tiagonmas added bug Something isn't working prio:High Issue of higher priority. Should be addressed first labels Jul 18, 2022
guerrerotook added a commit that referenced this issue Jul 19, 2022
@guerrerotook
Solved an issue where the subcription info wasn't synchronized betwee…
bb9fe5e 
…n the API and the databse. #675
@guerrerotook
Copy link
Contributor

This was an issue because I create the subscription with 5 years of expiration time, but in the database I have other code with other values.

I modified the code to use the PaymentSubcription object to synchronize all this data.

@tiagonmas
Copy link
Collaborator Author

Can you update to 100 years so "it does not expire" ? people can always go to account and cancel the subscription when they want

@guerrerotook
Copy link
Contributor

In the API the expiration time is optional meaning that it can be made not to expire. Could it be a good option also?

@tiagonmas
Copy link
Collaborator Author

sounds great

guerrerotook added a commit that referenced this issue Sep 16, 2022
@guerrerotook @tiagonmas
Merge developer into master (#685)
9d4a18e 
* Changed the way we started the subscription, the StartTime is calculated based on the Frequency.

* changes in tenant configuration and error message

* removed connection string

* Solved an issue where the subcription info wasn't synchronized between the API and the databse. #675

* BancoAlimentar.pt UI (#678)

* Started the integration of the design of the BancoAlimentar.

* Added the support for global layout for the tenants

* Progress with the bancoalimentar UI

* Added support for having a custom Service Principal in the KeyVaultConfiguration

* Fixed a layout issue

* Remove the main.min.css for the bancoalimentar.pt before the merging

* Added changes to the new BancoAlimentar tenant

* Added code to handle the Application Insights

* Better support for development environment.

* Solved some layout issues in the home page and login page.

* Closed #683 by upgrading the nuget packages.

* Solved build issues

* Solved build issues again.

* Fix tabs and spaces.

Co-authored-by: Tiago Andrade e Silva <[email protected]>
guerrerotook added a commit that referenced this issue Oct 5, 2022
@guerrerotook @tiagonmas
Feature/686 subscriptions make inactive in easypay when time has expi…
247cbc4 
…red (#687)

* Merge developer into master (#685)

* Changed the way we started the subscription, the StartTime is calculated based on the Frequency.

* changes in tenant configuration and error message

* removed connection string

* Solved an issue where the subcription info wasn't synchronized between the API and the databse. #675

* BancoAlimentar.pt UI (#678)

* Started the integration of the design of the BancoAlimentar.

* Added the support for global layout for the tenants

* Progress with the bancoalimentar UI

* Added support for having a custom Service Principal in the KeyVaultConfiguration

* Fixed a layout issue

* Remove the main.min.css for the bancoalimentar.pt before the merging

* Added changes to the new BancoAlimentar tenant

* Added code to handle the Application Insights

* Better support for development environment.

* Solved some layout issues in the home page and login page.

* Closed #683 by upgrading the nuget packages.

* Solved build issues

* Solved build issues again.

* Fix tabs and spaces.

Co-authored-by: Tiago Andrade e Silva <[email protected]>

* Update Payments-How-to-Test-while-Developing.md

* Update README.md

added link to youtube video

* Update the subscriptions from EasyPay

* Fix use tab vs spaces.

Co-authored-by: Tiago Andrade e Silva <[email protected]>
@tiagonmas
Copy link
Collaborator Author

I still see it as 5 years. Thought we were changing it to not expire @guerrerotook ?
image

@guerrerotook
Copy link
Contributor

If I don't set the Expiration time, this is the exception from the EasyPay API

Easypay.Rest.Client.Client.ApiException: 'Error calling SubscriptionPost: {"status":"error","message":["one of these fields must be set: expiration_time and max_captures"]}'

So, I guess that we have to set a maximum time. Should I change this to 10 years for example?

@tiagonmas
Copy link
Collaborator Author

yes, but could be 20 years :)

@guerrerotook
Copy link
Contributor

No, EasyPay API say a maximum of 15 years!

guerrerotook added a commit that referenced this issue Nov 30, 2022
@guerrerotook
Set the ExpirationTime to a maximum of 15 years. #675
a8373cf
@guerrerotook
Copy link
Contributor

So, I just created a subscription that expired in 15 years.

image

@tiagonmas
Copy link
Collaborator Author

Great!

guerrerotook added a commit that referenced this issue Nov 30, 2022
@guerrerotook
Merge the latest changes from developer (#713)
c8151d9 
* Solved an InvalidCastException when using the TenantStaticFileProvider

* Trying to solve the issue #711 by adding existing references of the user and the payment.

* Fixed issue #688 where the sorting by date is not correct in the datatable.

* Added the viewport option trying to fix the tests.

* Set the ExpirationTime to a maximum of 15 years. #675
guerrerotook added a commit that referenced this issue Dec 2, 2022
@guerrerotook
Merge developer into master. (#714)
37b8539 
* Solved an InvalidCastException when using the TenantStaticFileProvider

* Trying to solve the issue #711 by adding existing references of the user and the payment.

* Fixed issue #688 where the sorting by date is not correct in the datatable.

* Added the viewport option trying to fix the tests.

* Set the ExpirationTime to a maximum of 15 years. #675

* Fix an small issue with the Google Authentication

* Hope to finally fix the Address1 us null on this method.
@tiagonmas
Copy link
Collaborator Author

we can close this one, right @guerrerotook ?

@tiagonmas
Copy link
Collaborator Author

closing as it is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guerrerotook guerrerotook

Labels
bug Something isn't working prio:High Issue of higher priority. Should be addressed first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiagonmas @guerrerotook