Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/navigate notification #115

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Feat/navigate notification #115

merged 2 commits into from
Dec 7, 2023

Conversation

LuisParedes1
Copy link
Contributor

¿Qué hace esto?

Notification Navigation

¿Por qué hiciste esto?

Requisito

¿A quién/qué afecta esto?

End User

navigate.navigate('Snap', { snap: snap });
} catch (error) {
console.log(error);
alert('Sorry, snap deleted');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-alert> reported by reviewdog 🐶
Unexpected alert.

}}
>
{/* <Image
<TouchableOpacity onPress={handleNotification}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

>
{/* <Image
<TouchableOpacity onPress={handleNotification}>
<View className="max-w-md flex-1 overflow-hidden rounded-lg bg-white shadow-black">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

{/* <Image
<TouchableOpacity onPress={handleNotification}>
<View className="max-w-md flex-1 overflow-hidden rounded-lg bg-white shadow-black">
<View style={{ width: 2, backgroundColor: 'gray-800' }} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

{/* <Image
<TouchableOpacity onPress={handleNotification}>
<View className="max-w-md flex-1 overflow-hidden rounded-lg bg-white shadow-black">
<View style={{ width: 2, backgroundColor: 'gray-800' }} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-native/no-inline-styles> reported by reviewdog 🐶
Inline style: { width: 2, backgroundColor: 'gray-800' }


<FontAwesomeIcon icon={notif_metadata.icon} />

<View style={{ marginLeft: 11 }}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX


<FontAwesomeIcon icon={notif_metadata.icon} />

<View style={{ marginLeft: 11 }}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-native/no-inline-styles> reported by reviewdog 🐶
Inline style: { marginLeft: 11 }

<FontAwesomeIcon icon={notif_metadata.icon} />

<View style={{ marginLeft: 11 }}>
<Text style={{ fontSize: 18, fontWeight: '600' }}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

<FontAwesomeIcon icon={notif_metadata.icon} />

<View style={{ marginLeft: 11 }}>
<Text style={{ fontSize: 18, fontWeight: '600' }}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-native/no-inline-styles> reported by reviewdog 🐶
Inline style: { fontSize: 18, fontWeight: '600' }

<Text style={{ fontSize: 18, fontWeight: '600' }}>
{notification?.title}
</Text>
<Text>{notification?.content}</Text>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react/react-in-jsx-scope> reported by reviewdog 🐶
'React' must be in scope when using JSX

@LuisParedes1 LuisParedes1 merged commit abd90fc into main Dec 7, 2023
2 checks passed
@LuisParedes1 LuisParedes1 deleted the feat/navigate_notification branch December 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant