-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Acquia CLI #67
Conversation
With the opportunity to change the list, please put it on top, by the character < a > it is starting with (C case-insensitive collation sort). I'm aware that this is not the case for recent edits, but the original change-set suggest that. Then #45 suggests that tests needs to be extended and perhaps some read-me changes. Please compare as well with #49 . I'm fine if you amend and force push for the PR, but there is no requirement to do so. Thanks for your efforts. |
And please amend each commit with a message that reflects your understanding of the change. That would be helpful. And if then - separated by a single empty line - a reference to the original issue and maybe on another line to the PR - would be golden. This helps to keep track of changes over time. Short identifiers like < hash > + number is fine. |
Add Acquia CLI to list of supported tools, and reword sections to make it clear that only tools named console or on the list of default tools are supported out of the box bamarni#67 bamarni#66
I made the changes you suggested and also updated the README to hopefully avoid further confusion for users and contributors in my position.
I actually think it should be second on the list since |
Well spotted, very good thinking.
If you already have something of that prepared, you can also add another commit to this PR. Right now the acli link looks a bit alone in that list. |
Done, thanks. This should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care with the read-me. I'd love to see the change a bit shifted a bit towards the previous wording, especially for the point of what is supported, as your changes (naturally) put focus on the use-case of adding a utility to that list, but I know this is not the only use-case and I got the impression it has too much focus.
The best Idea I've come up with is to give the hint about how to add to that list after the list.
The Github CI build also was stale so it didn't properly run. I've updated master, just in case for the next update, if you refresh on top of master, it should show recovered. Sorry I didn't see this earlier. |
I adjusted the wording of the README |
Just seeing the list in the README isn't alphabetized fully, I guess because of console as first entry, but in the readme its composer. And I could start the build now and it shows its red. Please let me know if I can be of help. I might also be able to take a closer look later. |
I removed whitespace from the test fixture, I'm hoping that fixes tests. Otherwise I don't know what's going on. |
Thanks, looks good with the tests now. |
Released in 1.4.2. |
Thanks for the quick response! |
Fix #66
Follows examples of #45 and #49