Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chris-lipp and tommuelli #15

Closed
wants to merge 1 commit into from
Closed

Add chris-lipp and tommuelli #15

wants to merge 1 commit into from

Conversation

mikevader
Copy link
Contributor

Members of the CaT Code Camp Team

Config changes proposed in this pull request

  • Add team members for the CaT code camp team

For new organization members

I acknowledge that

  • I have read and understood the Open Source Guidelines
  • I agree to act accordingly (with due dilligence) to our guidelines
  • I have no open questions regarding the topics covered (please delete the "open questions" section)

Open questions

Members of the CaT Code Camp Team
@mikevader mikevader requested a review from a team as a code owner September 10, 2020 09:07
@MarkusTiede
Copy link
Contributor

Hi @mikevader - the idea is that each newly onboarded member files a PR on his / her own: and acknowledges the statements above (these are requirements of the cloud board). Does this makes sense?

Copy link
Contributor

@MarkusTiede MarkusTiede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split in two separate PRs create by each new individual member.

@MarkusTiede
Copy link
Contributor

At the moment we're gathering experience using this PR based approach - please feel free to add feedback here: baloise/open-source#257

@mikevader
Copy link
Contributor Author

I thought so after I saw the PR Template :)
But I said to my colleagues I would get it for them. But I will do it with them together in our next workshop.

@MarkusTiede can you tell me why the Travis CI has not reported back?

@christiansiegel
Copy link
Contributor

Travis CI tries to dry-run apply the config change. This turns out to be quite unreliable. We'll remove that soon. For now the admins can overrule the failed CI when merging.

@mikevader mikevader closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants