Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bal-3616): added demo account config option #3046

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

ArtemLavrentii
Copy link
Collaborator

@ArtemLavrentii ArtemLavrentii commented Feb 11, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a demo account option within customer and workflow settings, allowing enhanced configuration flexibility.
  • Chores

    • Updated development dependencies and improved package management settings for a more reliable build process.

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 42c25bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

Warning

Rate limit exceeded

@ArtemLavrentii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8748201 and 42c25bf.

📒 Files selected for processing (3)
  • apps/backoffice-v2/src/domains/customer/fetchers.ts (1 hunks)
  • package.json (1 hunks)
  • services/workflows-service/src/workflow/schemas/zod-schemas.ts (1 hunks)

Walkthrough

This pull request introduces a new boolean property named isDemoAccount into two schema definitions. In the backoffice domain, isDemoAccount is added to the configuration object of the customer fetcher with a default value of false. In the workflows service, the property is integrated into the configuration schema as an optional boolean. Additionally, changes in the package.json modify the devDependencies by re-adding both dotenv and prettier and include a new pnpm configuration section outlining built dependencies.

Changes

File(s) Change Summary
apps/backoffice-v2/…/fetchers.ts
services/workflows-service/…/zod-schemas.ts
Added a new isDemoAccount boolean property to schema configurations (default set to false in CustomerSchema; optional in ConfigSchema).
package.json Updated devDependencies: re-added dotenv and prettier; maintained openai version; added a new pnpm.onlyBuiltDependencies section.

Possibly related PRs

  • List customers and set customer config #2591: The changes in the main PR, which introduce the isDemoAccount property to the CustomerSchema, are related to the retrieved PR as both involve the addition of a similar property (isDemoAccount) to different schemas, indicating a shared focus on customer configuration.

Suggested reviewers

  • Omri-Levy

Poem

In code fields where changes bloom,
I hop with joy beneath the moon,
A new isDemoAccount takes its place,
Amidst updated deps in our space,
With tiny hops, I cheer the tune! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ArtemLavrentii ArtemLavrentii merged commit 49b3ae3 into dev Feb 13, 2025
17 of 18 checks passed
@ArtemLavrentii ArtemLavrentii deleted the bal-3616 branch February 13, 2025 15:26
chesterkmr added a commit that referenced this pull request Feb 14, 2025
* Dev 336/amplify webhook builds (#2906)

* feat: added new actions to build front-end apps manually

* fix: fixed a typo

* fix: changed the action names for the new front-end build actions

* feat: added on-failuew job to notify when the job fails

* fix: added changes code rabbit

* fix: removed redundant step for build action

* chore: removing on push trigger on the actions

* [bal-3442] - Backoffice - Display timestamp in local timezone for transaction monitoring (#3037)

* fix(transaction.mapper): remove unnecessary success log on validation (#3023)

- Eliminate console.log for successful validation
- Clean up the code for improved readability

(your logs are so verbose, they could be mistaken for a motivational speech)

* feat(docs): add development rules for backoffice-v2, kyb-app, workflows-dashboard (#3038)

* feat(docs): add development rules for backoffice-v2, kyb-app, workflows-dashboard

- Introduce best practices for React TypeScript development
- Include guidance on components, hooks, state management, and testing

(These rules are so thorough, they could double as a user manual for a space shuttle)

* docs(workflows): enhance workflow service rules and guidelines

- Expand code organization and structure guidelines
- Introduce TypeScript usage best practices
- Include detailed documentation on error handling and API design

(Your code organization is so messy, it makes a cluttered desk look like a minimalist art piece)

* chore: run dist with environment variables (#2643) (#3041)

* chore: run dist with environment variables (#2643)

* fix: adding trimmer in end of env name

---------

Co-authored-by: ChiragSharma <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>

* refactor(EditableDetails): optimize form handling with useMemo (#3048)

- Replace direct defaultValues assignment with memoized formValues
- Remove unnecessary useEffect for form reset on data change
- Simplify conditional rendering logic in the return statement

Co-authored-by: Alon Peretz <[email protected]>

* refactor(components): streamline details component properties access (#3049)

- Remove optional chaining for value.id and value.title
- Improve readability by ensuring direct property access

refactor(hooks): add workflowId to bankAccount and credit check blocks

- Update hooks to receive workflowId for better context handling
- Simplify conditional checks for plugin outputs

chore(migrations): update subproject commit reference

- Sync submodule to latest commit in workflows-service

* Use `report_outcomes` for report display (#3035)

* fix: table page

* wip

* fix: formating

* wip

* fix: small fixes

* fix

* fix: ui bug

* build: new version

* fix: validate report metadata

* fix: pr comments

* fix: pnpm-lock.json

* fix: update package

* fix: update package

* fix: update package

* fix: update package

* fix: update package

* fix: update package

* feat(bal-3616): added demo account config option (#3046)

* feat(bal-3616): added demo account config option

* chore: pr review fixes

* Illiar/feat/common document schemas (#3051)

* feat: added pci-certification document

* feat: added financial document && bump

* fix: lock fix

* fix: fixed backoffice crash & ui bump (#3053)

* fix: fixed incorect reason of revision (#3054)

---------

Co-authored-by: Chirag <[email protected]>
Co-authored-by: liorzam <[email protected]>
Co-authored-by: Alon Peretz <[email protected]>
Co-authored-by: pratapalakshmi <[email protected]>
Co-authored-by: ChiragSharma <[email protected]>
Co-authored-by: Shane <[email protected]>
Co-authored-by: Tomer Shvadron <[email protected]>
Co-authored-by: Matan Yadaev <[email protected]>
Co-authored-by: Artem Lavrentii <[email protected]>
Co-authored-by: Illia Rudniev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants