Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replaced react-helmet with react-helmet-async & fixed warning #1804

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: replaced react-helmet with react-helmet-async & fixed warning #1804

merged 4 commits into from
Dec 12, 2023

Conversation

chesterkmr
Copy link
Collaborator

  • fixed UNSAFE_componentWillMount warning by replacing react-helmet with react-helmet-async

Note: Solution idea taken from here Github Issue

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0589601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 11, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

tomer-shvadron
tomer-shvadron approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@tomer-shvadron tomer-shvadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@tomer-shvadron tomer-shvadron merged commit bd2520d into dev Dec 12, 2023
9 checks passed
@tomer-shvadron tomer-shvadron deleted the bal-932 branch December 12, 2023 11:03
MihirMandviwala pushed a commit that referenced this pull request Feb 12, 2024
@chesterkmr @tomer-shvadron
fix: replaced react-helmet with react-helmet-async & fixed warning (#…
cc44f00 
…1804)

* fix: replaced react-helmet with react-helmet-async & fixed warning

* fix: fixed tests & lock fix

---------

Co-authored-by: Tomer Shvadron <[email protected]>
southerneer
southerneer reviewed Jul 29, 2024
View reviewed changes
Copy link

@southerneer southerneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍊 . Great fix!

@Omri-Levy Omri-Levy mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southerneer southerneer southerneer left review comments

@tomer-shvadron tomer-shvadron tomer-shvadron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chesterkmr @southerneer @tomer-shvadron