Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: os: skip persistent logging test for pi0 #2989

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

rcooke-warwick
Copy link
Contributor

there is currently an issue with persistent logging on the rpi0 balena-os/balena-raspberrypi#927

in order to accelerate releases for this device type @alexgg suggested we could skip this test for the pi0, as its currently blocking

Change-type: patch
Signed-off-by: Ryan Cooke [email protected]


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@rcooke-warwick rcooke-warwick requested a review from alexgg January 30, 2023 15:42
@balena-ci balena-ci enabled auto-merge January 30, 2023 15:46
@rcooke-warwick rcooke-warwick force-pushed the ryan/rpi0-skip-persistent-logging branch from 2c126bb to 6ad11d8 Compare January 31, 2023 14:05
Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
@alexgg alexgg force-pushed the ryan/rpi0-skip-persistent-logging branch from 6ad11d8 to 2b35568 Compare January 31, 2023 15:32
@alexgg
Copy link
Contributor

alexgg commented Jan 31, 2023

lgtm

@balena-ci balena-ci merged commit 4586343 into master Jan 31, 2023
@balena-ci balena-ci deleted the ryan/rpi0-skip-persistent-logging branch January 31, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants