chore: make use of electron-builder for the package-electron target #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target builds a package for the current operating system, but doesn't create an installer out of it, which is useful for debugging purposes. Change-Type: patch Signed-off-by: Juan Cruz Viotti <[email protected]>
lurch
reviewed
Jun 23, 2017
| @@ -433,7 +434,14 @@ TARGETS = \ | |||
| installers-all \ | |||
| electron-develop | |||
|
|
|||
| package-electron: $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH) | |||
There was a problem hiding this comment.
So should the $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH) rule be removed too, if there's no target referencing it?
There was a problem hiding this comment.
The Linux rules still use that target. We will be able to remove it after merging the Linux electron-builder PR.
There was a problem hiding this comment.
Oh yeah, I hadn't spotted that $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-linux-$(TARGET_ARCH) is still being used :)
jviotti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This target builds a package for the current operating system, but
doesn't create an installer out of it, which is useful for debugging
purposes.
Change-Type: patch
Signed-off-by: Juan Cruz Viotti [email protected]