patch: Add Subresource Integrity to scripts being fetched #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
thgreasi
reviewed
Feb 19, 2024
| @@ -1,4 +1,4 @@ | |||
| <script src="//cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.15/lodash.min.js" type="text/javascript"></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.15/lodash.min.js" integrity="sha512-3oappXMVVac3Ge3OndW0WqpGTWx9jjRJA8SXin8RxmPfc8rg87b31FGy14WHG/ZMRISo9pBjezW9y00RYAEONA==" crossorigin="anonymous"></script> | |||
There was a problem hiding this comment.
The docs say that you could just use crossorigin as a tag w/o a value, and that should be equivalent to anonymous
Setting the attribute name to an empty value, like crossorigin or crossorigin="", is the same as anonymous.
But other than that lgtm 👍
See: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin#sect1
There was a problem hiding this comment.
TIL.
A field without a value is just confusion and an extra google search waiting to happen. Leaving it explicit makes the code self-explanatory.
thgreasi
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Subresource integrity to script tags in the docs.
Hash generated from: https://www.srihash.org/
Report: https://github.com/balena-io/docs/security/code-scanning/1
Solves: #2909
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]