Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose file docs #2092

Merged
2 commits merged into from
Jul 26, 2022
Merged

Update compose file docs #2092

2 commits merged into from
Jul 26, 2022

Conversation

robertgzr
Copy link
Contributor

Occasionally users try to use fields that are supported by v2 but have
different properties in version 3 (like long syntax for ports) and
are surprised to get an error in response.
Clarify that our support is based on version 2.4

Change-type: patch
Signed-off-by: Robert Günzler [email protected]

@robertgzr robertgzr force-pushed the rgz/compose_file_version branch from 071322c to caba857 Compare September 30, 2021 18:46
@klutchell
Copy link
Contributor

Do we actually support v2.4 fully? Why can't I put version: "2.4" at the top of my compose file, is it just a CLI bug?

@robertgzr
Copy link
Contributor Author

@klutchell hmm how did you try? balena push?

@klutchell
Copy link
Contributor

@robertgzr yeah, I get Unsupported composition version so it might need updating in the CLI

@robertgzr
Copy link
Contributor Author

@klutchell oohh yes definitely... see the hq issue for the list of todos

@robertgzr robertgzr force-pushed the rgz/compose_file_version branch from caba857 to 87fd232 Compare October 5, 2021 16:55
@klutchell
Copy link
Contributor

Should we wait to merge this until all of the related 2.4 support PRs have merged in the CLI, etc?

@robertgzr robertgzr force-pushed the rgz/compose_file_version branch 2 times, most recently from 85dfbce to 3b88c85 Compare October 26, 2021 12:34
@robertgzr robertgzr added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Oct 28, 2021
@robertgzr
Copy link
Contributor Author

robertgzr commented Oct 28, 2021

will remove the draft label when builder and cli changes are merged (deployed?)

@robertgzr
Copy link
Contributor Author

robertgzr commented Oct 29, 2021

  • update section on build.network being disallowed

@robertgzr robertgzr force-pushed the rgz/compose_file_version branch from d27848b to 398181e Compare October 29, 2021 13:52
Occasionally users try to use fields that are supported by v2 but have
different properties in version 3 (like long syntax for ports) and
are surprised to get an error in response.
Clarify that our support is based on version 2.4

Change-type: patch
Signed-off-by: Robert Günzler <[email protected]>
@robertgzr robertgzr force-pushed the rgz/compose_file_version branch from 398181e to 0ad71be Compare December 1, 2021 13:50
@vipulgupta2048
Copy link
Member

@robertgzr Hey, what if we can automate this page to generate documentation as per the version we support? Can we do that if it is possible?

@robertgzr
Copy link
Contributor Author

@vipulgupta2048 I'm not sure about that. Right now the properties we do and don't support result from our code in compose-parse, with the actual implementation scattered between multibuild (for buildtime) and supervisor (for runtime)

and sometimes there is partial support (like with depends_on introduced here)

maybe we can express the information that is needed here in a json schema form though? we already kind of use one...

@robertgzr
Copy link
Contributor Author

another thing that came to mind is where this documentation actually appears. It's not obvious to me why it's part of the supervisor reference, since it matters at build time as well (which is more cloud/cli doc)

@vipulgupta2048
Copy link
Member

Oh wow, this got left behind quite a bit @robertgzr
Can you add #2189 to this PR and we can finish this.

My automation request was a more of a suggestion, although maybe the engine should have a contract of what properties it supports to help list things out in a better way.

@robertgzr
Copy link
Contributor Author

@vipulgupta2048 you can check https://github.com/balena-io/balena-io/issues/2311#issuecomment-931564390, this work is stalled until I or somebody finds the time to investigate the breakage we get from using livepush with target directive

we should keep this PR open until those things are all completed I think...

@dfunckt
Copy link
Member

dfunckt commented Jul 26, 2022

@balena-ci rebase

@ghost ghost force-pushed the rgz/compose_file_version branch from 0ad71be to 3c9a46a Compare July 26, 2022 13:14
@ghost ghost merged commit 8965031 into master Jul 26, 2022
@ghost ghost deleted the rgz/compose_file_version branch July 26, 2022 13:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants