Use deep imports for date-fns to improve tree-shaking #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
changed the title
thgreasi
force-pushed
the
date-dns-deep-imports
branch
from
1515d0a to
22ac680
Compare
thgreasi
commented
Nov 4, 2022
lib/util/date.ts
Outdated
Comment on lines
1
to
2
| // TODO: Remvove the deep imports once we start offering an esm build | ||
| // and confirm that tree-shaking date-fns still works. |
There was a problem hiding this comment.
Actually, I think that the CLI would benefit from a deep import, since it will always have to parse less files, regardless of switching to esm or not 🤔
Had to enable esModuleInterop, b/c otherwise the date-fns/formatDistance import not returning anything, even though TS was happy. Change-type: patch Signed-off-by: Thodoris Greasidis <[email protected]>
thgreasi
force-pushed
the
date-dns-deep-imports
branch
from
22ac680 to
adba24b
Compare
Change-type: patch See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/moment.20-.3E.20date-fns Signed-off-by: Thodoris Greasidis <[email protected]>
thgreasi
force-pushed
the
date-dns-deep-imports
branch
from
adba24b to
99f44b5
Compare
Signed-off-by: Thodoris Greasidis <[email protected]>
thgreasi
force-pushed
the
date-dns-deep-imports
branch
from
99f44b5 to
7701562
Compare
|
@balena-ci I self-certify! |
ghost
approved these changes
Nov 4, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/moment.20-.3E.20date-fns
Signed-off-by: Thodoris Greasidis [email protected]
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch
Contributor checklist