build, deploy: Add support for multi-architecture base images #2145
Conversation
pdcastro
force-pushed
the
1408-1508-docker-multiarch-images
branch
from
a3f183d to
d6edd64
Compare
| @@ -256,7 +256,7 @@ | |||
| "resin-compose-parse": "^2.1.2", | |||
| "resin-doodles": "^0.1.1", | |||
| "resin-image-fs": "^5.0.9", | |||
| "resin-multibuild": "^4.7.2", | |||
| "resin-multibuild": "^4.10.0", | |||
There was a problem hiding this comment.
This one line is the "core feature implementation" really... The rest of the PR is about printing warns and hints to the user about Docker compatibility and usage of the --pull and --emulated options in combination with multiarch base images.
pdcastro
added
the
versionbot/pr-draft
|
@pdcastro @srlowe is fix this blocked by anything? I am also affected by this, via #2174 cc @klutchell |
I've come across complications... Started an FD thread and pinged you guys here: |
|
[rahul-thakoor] This pull request has attached support thread https://jel.ly.fish/f0910369-0b58-48f3-9214-1e6fe0d16388 |
pdcastro
force-pushed
the
1408-1508-docker-multiarch-images
branch
from
d6edd64 to
7f93d78
Compare
pdcastro
removed
the
versionbot/pr-draft
Change-type: minor
pdcastro
force-pushed
the
1408-1508-docker-multiarch-images
branch
from
7f93d78 to
92f48aa
Compare
| ); | ||
| } | ||
|
|
||
| /** Detect whether the docker daemon is Docker Desktop (Windows or Mac) */ | ||
| export async function isDockerDesktop( |
There was a problem hiding this comment.
This function was extracted / refactored from lib/utils/qemu.ts.
| support for multi-architecture base images to be lost. | ||
| * Manually run the 'docker pull' command for all base images listed in your | ||
| Dockerfile(s) prior to executing the 'balena build' or 'balena deploy' | ||
| commands, and then do not use the balena CLI's '--pull' flag. |
There was a problem hiding this comment.
Just learned that this advice is insufficient / incorrect with Docker v20.10.4 and v20.10.5. This PR will require further changes. :-/
https://www.flowdock.com/app/rulemotion/i-cli/threads/RuSu1KiWOn62xaGy7O2sn8m8BUc
|
Connects-to / somewhat blocked by:
"Somewhat blocked" because if we really can't resolve the issues above, there are alternative plans: |
|
Closing in favour of #2301 |
Resolves: #1408
Resolves: #1508
Change-type: minor