Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balena logs command should use a keepalive for local devices #1219

Closed
CameronDiver opened this issue May 13, 2019 · 0 comments · Fixed by #1220
Closed

balena logs command should use a keepalive for local devices #1219

CameronDiver opened this issue May 13, 2019 · 0 comments · Fixed by #1220
Assignees
@CameronDiver

Comments

@CameronDiver
Copy link
Contributor

If a device goes offline, the logs stream doesn't reflect that. We should use a TCP keepalive to detect this.

Please keep in mind that we try to use the issue tracker of this repository for specific bug reports & CLI feature requests. General & troubleshooting questions are encouraged to be posted to the balena forums where the community can both contribute and benefit from the answers.

Before submitting this issue please check that this issue is not a duplicate. If there is another issue describing the same problem or feature please add your information to the existing issue's comments.
@CameronDiver CameronDiver self-assigned this May 13, 2019
CameronDiver pushed a commit that referenced this issue May 13, 2019
Use TCP keepalive probes to detect local log stream closing
440501c 
Change-type: patch
Closes: #1219
Signed-off-by: Cameron Diver <[email protected]>
@CameronDiver CameronDiver mentioned this issue May 13, 2019
Merged
2 tasks
CameronDiver pushed a commit that referenced this issue May 14, 2019
Use TCP keepalive probes to detect local log stream closing
dffa86a 
Change-type: patch
Closes: #1219
Signed-off-by: Cameron Diver <[email protected]>
CameronDiver pushed a commit that referenced this issue May 14, 2019
Use TCP keepalive probes to detect local log stream closing
962cf13 
Change-type: patch
Closes: #1219
Signed-off-by: Cameron Diver <[email protected]>
CameronDiver pushed a commit that referenced this issue May 14, 2019
Use TCP keepalive probes to detect local log stream closing
5250099 
Change-type: patch
Closes: #1219
Signed-off-by: Cameron Diver <[email protected]>
CameronDiver pushed a commit that referenced this issue May 14, 2019
Use TCP keepalive probes to detect local log stream closing
96c975d 
Change-type: patch
Closes: #1219
Signed-off-by: Cameron Diver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CameronDiver CameronDiver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TCP keepalive probes to detect local log stream closing balena-io/balena-cli
1 participant
@CameronDiver