Return ISODateString instead of date
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fisehara Can you add the reasoning as part of the commit for easier future reference? |
fisehara
force-pushed
the
fisehara/return-iso_date_string
branch
from
9b447bc to
115079f
Compare
Page-
reviewed
Mar 4, 2024
The internal and external representation of the returned object from pinejs should be consistent. Pinejs internal interface will return date or date time fields as date object. For the external interface the object is JSON.stringified so that date becomes an ISO string anyway. Change-type: major Signed-off-by: fisehara <[email protected]>
fisehara
force-pushed
the
fisehara/return-iso_date_string
branch
from
115079f to
37e2d44
Compare
Page-
approved these changes
Mar 4, 2024
fisehara
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 5, 2024
Update `@balena/sbvr-types` from 6.1.1 to 7.0.1 pinejs provides an internal and external interface. The external interface returns ISODateString encoded data. The internal interface should be consistent to the external interface, so that the pinejs api internally used also returns an ISODateString encoded data. This is solvedi n `sbvr-types` and is a major in the submodule and made this also a major change for pinejs itself. balena-io-modules/sbvr-types#91 Change-type: major Signed-off-by: Harald Fischer <[email protected]>
fisehara
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 5, 2024
Update `@balena/sbvr-types` from 6.1.1 to 7.0.1 pinejs provides an internal and external interface. The external interface returns ISODateString encoded data. The internal interface should be consistent to the external interface, so that the pinejs api internally used also returns an ISODateString encoded data. This is solvedi n `sbvr-types` and is a major in the submodule and made this also a major change for pinejs itself. balena-io-modules/sbvr-types#91 Change-type: major Signed-off-by: Harald Fischer <[email protected]>
fisehara
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 6, 2024
Update `@balena/sbvr-types` from 6.1.1 to 7.0.1 pinejs provides an internal and external interface. The external interface returns ISODateString encoded data. The internal interface should be consistent to the external interface, so that the pinejs api internally used also returns an ISODateString encoded data. This is solved in `sbvr-types` and is a major in the submodule and made this also a major change for pinejs itself. balena-io-modules/sbvr-types#91 Change-type: major Signed-off-by: Harald Fischer <[email protected]>
fisehara
added a commit
to balena-io/pinejs
that referenced
this pull request
Mar 8, 2024
…API interface for date and date time fields. Update `@balena/sbvr-types` from 6.1.1 to 7.0.1 pinejs provides an internal and external interface. The external interface returns ISODateString encoded data. The internal interface should be consistent to the external interface, so that the pinejs api internally used also returns an ISODateString encoded data. This is solved in `sbvr-types` and is a major in the submodule and made this also a major change for pinejs itself. balena-io-modules/sbvr-types#91 Change-type: major Signed-off-by: Harald Fischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: major