Use effects for actions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unrelated to the PR but the eslint LSP is buggy and slows down my editor. Change-type: patch
Observables now are composable via `map` and `flatMap`, they can also now accept async iterators as input, which should simplify the way sensors and action observables are defined. Change-type: minor
The `Effect` type is a mix between a promise, a function and an observable. It provides a way to combine an async computation with a sync version which "simulates" the effect that the async computation will have on the underlying system. These types are also composable via `map` and `flatMap`, which would allow building more complex effects from simpler ones, however this is outside the scope of the current PR (see PR #33 for a use of those ideas). Change-type: minor
Actions obtained from primitive tasks now return an Effect by default, making them both awaitable and observable. This change is compatible with the existing API Change-type: minor
Changing the task definition also changed the Ids defined for tasks, thus breaking Mermaid tests. This fixes the test suite Change-type: patch
pipex
force-pushed
the
use-effects-for-actions
branch
from
cb19a29 to
816f71e
Compare
|
I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Effecttype to deal with asynchronous computations performed by actions returned from primitive tasks.The
Effecttype is a mix between a promise, a function and anobservable. It provides a way to combine an async computation with a
sync version which "simulates" the effect that the async computation
will have on the underlying system. These types are also composable via
mapandflatMap, which would allow building more complex effectsfrom simpler ones, however this is outside the scope of the current PR
(see PR #33 for a use of those ideas).
This PR changes the
Actiontype to return effects instead of a Promisewhich makes all actions observable by default, while keeping the action result
awaitable. This change is compatible with the existing API
Change-type: minor