Update pinejs-client and make use of improved typings #54
Conversation
| .get({ | ||
| resource: 'user', | ||
| id, | ||
| options: { $select: 'id' }, |
There was a problem hiding this comment.
This $select was previously missing
| .get({ | ||
| resource: 'application', | ||
| id, | ||
| options: { $select: 'id' }, |
There was a problem hiding this comment.
This $select was previously missing
| options: { $select: 'id' }, | ||
| } as const) | ||
| .catch(models.wrapResponseError); | ||
| if (user == null) { |
There was a problem hiding this comment.
It could always be null but in the past it would have error'ed with something like TypeError: cannot read 'id' of undefined downstream
| options: { $select: 'id' }, | ||
| } as const) | ||
| .catch(models.wrapResponseError); | ||
| if (app == null) { |
There was a problem hiding this comment.
It could always be null but in the past it would have error'ed with something like TypeError: cannot read 'id' of undefined downstream
| } | ||
|
|
||
| async function getOrCreateService( | ||
| api: PinejsClientCore<unknown>, | ||
| body: models.ServiceAttributes, | ||
| ): Promise<models.ServiceModel> { | ||
| return models.getOrCreate(api, 'service', body, { |
There was a problem hiding this comment.
I replaced this with the built in getOrCreate to keep things standardized with other repos using the client
package.json
Outdated
| "pinejs-client-core": "^6.15.10", | ||
| "pinejs-client-request": "^7.5.2", |
There was a problem hiding this comment.
Since the sdk is pinned to ~6.14.0, bumping these would cause headaches in the CLI by causing it to have to separate versions of pinejs-client-core. Would it be a big deal deferring this bump for a bit (until the next sdk major)?
Page-
force-pushed
the
update-pinejs-client
branch
from
6ad2ec9 to
01937a9
Compare
Pull request was converted to draft
Page-
force-pushed
the
update-pinejs-client
branch
from
01937a9 to
60117af
Compare
Page-
force-pushed
the
update-pinejs-client
branch
2 times, most recently
from
8b71424 to
1085c2c
Compare
Change-type: patch
Page-
force-pushed
the
update-pinejs-client
branch
from
1085c2c to
055a907
Compare
Change-type: patch