Fix CI error of tar files created on mac #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tar files created with mac computers are including a lsetxattr header that docker engine doesn't seem to be able to handle, this just recreate the tar files without such headers See: moby/moby#47517 See: https://eclecticlight.co/2023/03/13/ventura-has-changed-app-quarantine-with-a-new-xattr/ Change-type: patch
|
@thgreasi The current failing tests are So we need to either do a major bump deprecating them in this package or somehow enable format v1/manifest v2 on the CI runners |
otaviojacobi
force-pushed
the
fix-ci
branch
2 times, most recently
from
1e9afb9 to
6634200
Compare
otaviojacobi
requested review from
dfunckt,
thgreasi and
pipex
and removed request for
pipex
otaviojacobi
force-pushed
the
fix-ci
branch
2 times, most recently
from
b73b538 to
adbcbd7
Compare
Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Change-type: major
|
superseded by #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar files created with mac computers are including a lsetxattr header that docker engine doesn't seem to be able to handle, this just recreate the tar files without such headers
See: moby/moby#47517
See: https://eclecticlight.co/2023/03/13/ventura-has-changed-app-quarantine-with-a-new-xattr/
Change-type: patch