Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disposing the docker daemon request on non-network errors #38

Closed
wants to merge 2 commits into from

Conversation

thgreasi
Copy link
Contributor

@thgreasi thgreasi commented Nov 9, 2023

Change-type: patch
See: balena-io-modules/resin-docker-build#31

@thgreasi thgreasi force-pushed the fix-node20-orphan-daemon-request branch from 5f80e11 to 1e08607 Compare November 9, 2023 16:04
@thgreasi thgreasi requested a review from dfunckt November 9, 2023 16:05
@Page-
Copy link
Contributor

Page- commented Nov 13, 2023

Is there an explanation of why these changes help? Also I would assuming using pipeline instead of .pipe chains will likely help things by allowing for more automatic error handling/propogation that might otherwise get missed

@thgreasi
Copy link
Contributor Author

Closed in favor of #42

@thgreasi thgreasi closed this Nov 27, 2023
@thgreasi thgreasi deleted the fix-node20-orphan-daemon-request branch November 27, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants