Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated write typings when WebResource are included #53

Closed
wants to merge 1 commit into from
Closed

Fix generated write typings when WebResource are included #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ type RequiredModelSubset = Pick<
'tables' | 'relationships' | 'synonyms'
>;

const webResource = `export interface WebResource {
filename: string;
href: string;
content_type?: string;
content_disposition?: string;
size?: number;
};`;
const typeHelpers = {
read: `
export type DateString = string;
Expand All @@ -29,15 +36,11 @@ export type Deferred<T> = Exclude<T, any[]>;
export type PickDeferred<T, K extends keyof T> = {
[P in K]: Deferred<T[P]>;
};
export interface WebResource {
filename: string;
href: string;
content_type?: string;
content_disposition?: string;
size?: number;
};
${webResource}
`,
write: `
${webResource}
`,
write: '',
};

const trimNL = new TemplateTag(
Expand Down
12 changes: 11 additions & 1 deletion test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,17 @@ const test = (
${expectation}
`);
} else {
expect(result).to.equal(expectation);
expect(result).to.equal(source`
export interface WebResource {
filename: string;
href: string;
content_type?: string;
content_disposition?: string;
size?: number;
};

${expectation}
`);
}
});
};
Expand Down
Loading