Update node to 20, make sbvr-types a peer dependency, update dependencies & tests to match #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
update-dependencies
branch
from
8b6f93b to
dae9f0e
Compare
thgreasi
changed the title
thgreasi
changed the title
Page-
reviewed
Oct 4, 2024
| @@ -57,8 +59,8 @@ | |||
| ] | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.13.0", | |||
| "npm": ">=8.1.0" | |||
| "node": ">=20.14.0", | |||
There was a problem hiding this comment.
Can you update tsconfig to es2023 to match this
There was a problem hiding this comment.
Good reminder!
@Page- TS wiki mentions target es2022 & lib es2023 for node 20, so I guess we should go with that, right?
https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-20
There was a problem hiding this comment.
I think that's outdated since it talks about using node.green and node.green says that target es2023 should be fine for nodejs 20
There was a problem hiding this comment.
Should we also move to "module": "Node16", ?
Page-
reviewed
Oct 4, 2024
package.json
Outdated
| "@types/common-tags": "^1.8.4", | ||
| "@types/lodash": "^4.17.10", | ||
| "@types/mocha": "^10.0.8", | ||
| "@types/node": "^22.7.4", |
There was a problem hiding this comment.
This should still be nodejs 20 since that's what is targeted
Update @balena/lf-to-abstract-sql from 5.0.0 to 5.0.2 Update @balena/odata-parser from 3.0.0 to 3.1.0 Update @balena/odata-to-abstract-sql from 6.0.1 to 6.4.0 Update @balena/sbvr-parser from 1.4.3 to 1.4.6 Update @balena/sbvr-types from 7.0.1 to 9.0.2 Change-type: patch
Change-type: patch
Change-type: major
Change-type: major
Change-type: major
thgreasi
force-pushed
the
update-dependencies
branch
from
b0828b5 to
9fa6236
Compare
Change-type: patch
Page-
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update @balena/lf-to-abstract-sql from 5.0.0 to 5.0.2
Update @balena/odata-parser from 3.0.0 to 3.1.0
Update @balena/odata-to-abstract-sql from 6.0.1 to 6.4.0
Update @balena/sbvr-parser from 1.4.3 to 1.4.6
Update @balena/sbvr-types from 7.0.1 to 9.0.2
Change-type: major