Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when using #line directive, or with symbols on the last line of a file #5

Closed
baldurk opened this issue Feb 28, 2014 · 2 comments
Closed

Crash when using #line directive, or with symbols on the last line of a file #5

baldurk opened this issue Feb 28, 2014 · 2 comments
Labels
Bug A crash, misbehaviour, or other problem

Comments

@baldurk
Copy link
Owner

baldurk commented Feb 28, 2014

RenderDoc's disassembler doesn't correctly handle the #line directive, and if you end up with line numbers beyond the number of lines in the file (quite easy) it will crash indexing off the end of the file.

Otherwise, the line numbers are still wrong!
@baldurk baldurk added the bug label Feb 28, 2014
@baldurk baldurk added this to the Release v0.19 milestone Feb 28, 2014
@baldurk
Copy link
Owner Author

baldurk commented Mar 1, 2014

Updating the topic - thanks to investigations on #4 I've found an off-by-one error in line number indexing - debug info returns line numbers 1-indexed and I look them up 0-indexed, which causes incorrect hlsl lines embedded in the disassembly as well as a potential lookup off the end of the array.

oops!

@baldurk baldurk mentioned this issue Mar 1, 2014
Closed
@baldurk
Copy link
Owner Author

baldurk commented Mar 1, 2014

Fixed in 7336220f, due in v0.19. Possibly also fixes #4, we'll see!

@baldurk baldurk closed this as completed Mar 14, 2014
baldurk added a commit that referenced this issue Feb 16, 2016
@baldurk
[Sparse #5] Implement stubs for updating page tables (opaque or image)
fe84403 
* Not supporting images with arrays or mips for now as that becomes
  more complicated. In theory a page table each, but then need to handle
  mip tail and stuff.
@Vtec234 Vtec234 mentioned this issue May 14, 2017
Closed
@Yours3lf Yours3lf mentioned this issue Jul 7, 2017
Closed
@bradc6 bradc6 mentioned this issue Jun 22, 2018
Closed
@penguin42 penguin42 mentioned this issue Nov 9, 2018
Closed
@mimijava mimijava mentioned this issue Jul 4, 2019
Closed
@eaglefly628 eaglefly628 mentioned this issue Jul 19, 2021
Closed
CamilliaX pushed a commit to CamilliaX/renderdoc that referenced this issue Aug 14, 2023
@CamilliaX
baldurk#5
3bfa77f
@xjqxzyr xjqxzyr mentioned this issue Aug 23, 2023
Closed
@wtmilk wtmilk mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A crash, misbehaviour, or other problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baldurk