Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send stack track back for body parse errors when environment is production #3347

Merged
merged 1 commit into from
Dec 23, 2015
Merged

don't send stack track back for body parse errors when environment is production #3347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/hooks/http/middleware/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ module.exports = function(sails, app) {
// is overridden in userland. Should probably be phased out at some point,
// since it could be accomplished more elegantly- btu for now it's practical.)
handleBodyParserError: function handleBodyParserError(err, req, res, next) {
if(IS_PRODUCTION){
return res.send(400);
}
var bodyParserFailureErrorMsg = 'Unable to parse HTTP body- error occurred :: ' + util.inspect((err&&err.stack)?err.stack:err, false, null);
sails.log.error(bodyParserFailureErrorMsg);
return res.send(400, bodyParserFailureErrorMsg);
Expand Down