Add 'My pool balance' card to invest flow #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyboxer
reviewed
Oct 15, 2021
| /** | ||
| * COMPUTED | ||
| */ | ||
| const bptBalance = computed((): string => balanceFor(props.pool.address)); |
There was a problem hiding this comment.
Is there a difference between this way of typing and computed<string>? (I've mostly been using it when it isn't inferred correctly.
evgenyboxer
approved these changes
Oct 15, 2021
arb000r
approved these changes
Oct 15, 2021
It only showed the pool weights essentially, which we show in the main form. We could potentially add to this side module as well but I'm not sure it will add much. |
garethfuller
added a commit
that referenced
this pull request
Oct 20, 2021
* 1.23.0 (#932) * Only include sentry source map plugin if token provided * 1.23.1 * Fix approvals in old invest flow * 1.23.2 * Fix vue warning * Don't display unnecessary warnings * 1.23.3 * Correctly handle wallet not connected error * Clean up conditionals * hotfix/1.23.4 (#943) * Hotfix 1.23.3 - Fix trade errors display logic (#939) * Don't display unnecessary warnings * 1.23.3 * Correctly handle wallet not connected error * Clean up conditionals * fix: guard provider from possibly being null * fix: check pending transactions only when a wallet is connected * 1.23.4 Co-authored-by: Gareth Fuller <[email protected]> * Allow ETH investments in WETH pools (#944) * Fix weight string/number vue warning * More accuretly type computed properties * Refactor BalPopover * Fix props * Pass in tokensIn instead of pulling from pool * Allow ETH investments in WETH pools * Add wrappedNativeAsset property to tokens provider * Refactor and used wrappedNativeAsset instead of reference to WETH * Fix tooltip widths * Remove proportional suggestions from stable pool investments * fix: add missing entry for Arbitrum in network prefix map (#945) * Add a switch for Balancer <> Gnosis trading (#757) * feat: toggle switch * fix: gasless trading toggle + gasless query param * fix: error msg * feat: enable gnosis trading on supported networks only * remove trade interface references * fix: change casing of local storage key * Add unit test for hotfix 1206 (#918) * Create unit test for useSor - Create a basic unit test for useSor with mocked dependencies. - Add a test that calls setSwapCost and ensures the correct token price is passed to SorManager. - Rather than manually defining each mock in every test file, move them to mock files that can be loaded when required. This way mocks can be used amongst many tests easily. - Move all test files out of tests directory to be beside the files that they are testing. - Use jsdom and vue-composable-tester to mount useSor to a component. - Change jest.config.js to use nodejs runner for spec.node.ts files and jsdom runner for others. - Add new mocks for vue store and tokens. * Add 'My pool tokens' card to invest flow (#948) * Refactor BalBreakdown * Refactor calculator service to adjust if investing with native asset * Update calculator inputs * Update usage of BalBreakdown * Add MyWalletTokensCard and allow for native asset selection * Update locales * Fix fiatTotal and update labels * Add network name 'eyebrow' * Minro style fix * fix: Border colors in darkMode * fix: Remove dividing lines * refactor: Remove redundant computed property and re-org imports * Add 'My pool balance' card to invest flow (#949) * feat: Add MyPoolBalancesCard to invest page * chore: Update locales * fix: Add missing PoolCalculator input * version bump * Update MultiTokenLiquidityMining.json (#954) ## Ethereum - No changes this week. ## Arbitrum - Reduce DEFI5/WETH/WBTC 33/33/33 to 0 Flexible BAL per week. This pool will now receive 0 BAL per week. - Increase BAL/WETH 60/40 by 500 Flexible BAL per week. This pool will now receive 4,000 BAL per week. ## Polygon - No changes this week. Co-authored-by: bakamoto20 <[email protected]> * fix: update tooltip (#951) * bring back trade interface (#957) * Responsive design for invest flow (#952) * style: Allow hiding of component header * feat: Add BalAccordian component * style: Move invest flow side modules into accordians on mobile * fix: Remove stray z * fix: Remove Saf log * fix: BalAccordian hover state in dark mode * UI 568 trade UI improvements (#882) * merge: dev * feature: add trade ui widgets * feature: add balcarousel * update: add more customisation to the ballinechart component * feature: add trade pair snapshots to the subgraph service * add widgets to the trade page * update: add in shared trade state among widgets and fix bugs and add error state * update: add in wallet connection button and loading state to my wallet widget * update: lazy loading of price graph widget data and fix change calcs * update: add aggregation options to the pricing service * fix: loading states * fix: make charts actually show trends properly * update: add ability to switch timespans and some style changes * update: use css transforms instead of moving position * update: convert pairpricegraph widget to script setup * update: convert mywallet widget to script setup * update: use native asset instead of hardcoded eth symbol * update: remove unecesary props from balcard * update: add comments to ballinechart * fix: lint * fix: add guard for price * update: move functions out of tradestate composable * update: add explicit types * update: capitalise constants * update: move trending pairs query to querykeys and add network dep * update: querykeyify pairpricegraph * fix: lint * update: adjust animation * update: mobile adjustments * fix: lint * fix: locales * fix: maximise button placement * fix: style bugs * fix: style bugs * fix: max assets per line * fix: balassetset * fix: lint * feature: balaccordion to replace carousel on mobile * fix: mobile styles * fix: more mobile styles * temp: test transform * temp: test height moving transform * update: add opacity * update: speed up the easing * update: chart modal * fix: more bugfixes * update: make link * update: pon adjustments * update: cleanup * update: cleanup and feature flag widgets * fix: build * sync defaults * fix: Remove log * fix: Hide trade timeout setting if not gasless and if invest context * 1.24.0 * fix: Prop type syntax * fix: chart height and add comments * fix: lint * Revert version update * 1.24.0 Co-authored-by: Evgeny Boxer <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Tim Robinson <[email protected]> Co-authored-by: Markus Buhatem Koch <[email protected]> Co-authored-by: bakamoto20 <[email protected]> Co-authored-by: Ansaf Ahmed <[email protected]> Co-authored-by: 1saf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a card to the right of the investment form that displays any existing pool balance the user has. The balances for individual pool tokens are derived from a proportional exit using their full BPT balance.
Again, this PR does not cover the mobile layout, that will be done in a later PR when all the page elements are included.
Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Checklist:
masterif hotfix,developif not