Token balances/allowances error alerts #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyboxer
commented
Sep 6, 2021
| type: AlertType.ERROR, | ||
| persistent: true, | ||
| action: refetchPrices.value, | ||
| actionLabel: t('alerts.retry-label'), | ||
| priority: AlertPriority.MEDIUM | ||
| }); | ||
| } else { | ||
| removeAlert('price-error'); | ||
| removeAlert('price-fetch-error'); |
There was a problem hiding this comment.
minor refactor to have the error names consistent
evgenyboxer
commented
Sep 6, 2021
| "price-provider-down": "Our pricing provider, Coingecko is currently down.", | ||
| "price-fetch-error": "Our pricing provider, Coingecko is currently down.", | ||
| "balances-fetch-error": "Failed to fetch token balances.", | ||
| "allowances-fetch-error": "Failed to fetch token allowances.", |
There was a problem hiding this comment.
these might change
evgenyboxer
changed the title
garethfuller
approved these changes
Sep 7, 2021
garethfuller
deleted the
evgeny/ui-732-token-balancesallowances-alert
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds error alerts for token balances/allowances - these are considered pretty major (can't really trade) which is why they are "app level" alerts. (obviously these will only be shown when a wallet is connected)
Here's how it looks:
Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Checklist:
masterif hotfix,developif not