Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Properly handle null price rates in stable pool maths #776

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

TomAFrench
Copy link
Contributor

Description

The subgraph returns nulls for stable pool price rates however the frontend is expecting to get undefined. This means that null price rates were slipping through and blowing up the maths.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Attempt to join/exit a stable pool. (just being able to add an input is enough)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/H8zhySS5txg6wZUGaTJ3Nrxq4no4
✅ Preview: Canceled

app – ./

🔍 Inspect: https://vercel.com/balancer/app/HGh1jWWRh4J7xbYD2r2C9e5J6sC1
✅ Preview: Canceled

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/AdFJbQDjcoJBy8GWf56kQn2sxAFk
✅ Preview: https://staging-app-git-hotfix-stable-pool-maths-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/CHeUqm8f4xwQDUoGzJySGeeLd4Bg
✅ Preview: https://staging-kovan-app-git-hotfix-stable-pool-maths-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/BbUC7aZtBT1QcfqQK6W1fmNFCDuj
✅ Preview: https://gnosis-git-hotfix-stable-pool-maths-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/HmnbDDEeDEVw5P2g86Uhi3Vvdjhe
✅ Preview: Canceled

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/CqXNWVQVg9i8KRtXVhUZKZHJQKWt
✅ Preview: https://beta-polygon-git-hotfix-stable-pool-maths-balancer.vercel.app

beta-arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/beta-arbitrum/EHJ9YvPDcQ3Gh1Vs3xq5GF2KyGnp
✅ Preview: https://beta-arbitrum-git-hotfix-stable-pool-maths-balancer.vercel.app

arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/arbitrum/G583BLLVroC1GN7f8BZNy79H3oMT
✅ Preview: Canceled

@TomAFrench TomAFrench merged commit edf6109 into master Aug 31, 2021
@garethfuller garethfuller deleted the hotfix-stable-pool-maths branch August 31, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants