Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Polygon to use Blocknative #748

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

evgenyboxer
Copy link
Contributor

@evgenyboxer evgenyboxer commented Aug 27, 2021

Description

The latest release of bnc-sdk adds support for Polygon 🎉

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • I have tested this locally and indeed I'm getting events from blocknative now

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@linear
Copy link

linear bot commented Aug 27, 2021

@vercel
Copy link

vercel bot commented Aug 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/8FGpQsxSuYyni6eShHdPuFSHLFPi
✅ Preview: Canceled

[Deployment for 3dc321f canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/6B4DbuwPZLH5ooPprejJYzV6YRhL
✅ Preview: Canceled

[Deployment for 3dc321f canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/B64GLQCGaGBQCZFTmHh1gz3bcWLd
✅ Preview: https://staging-app-git-evgeny-ui-724-update-bnc-sdk-to-969cd7-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/5VjtztZngFfyRJhRgio888FU4V7t
✅ Preview: https://staging-kovan-app-git-evgeny-ui-724-update-bnc-05b530-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/3VGi4JmiQ9J3GiqxfDuF4TVYwpb6
✅ Preview: https://gnosis-git-evgeny-ui-724-update-bnc-sdk-to-supp-a3967b-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/6bYKt3vkD1myjJQ2SCyBbc9VN9of
✅ Preview: Canceled

[Deployment for 3dc321f canceled]

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/2G8vNK7tvnbKbZ3WWHLDh9yaGYon
✅ Preview: https://beta-polygon-git-evgeny-ui-724-update-bnc-sdk-t-012809-balancer.vercel.app

beta-arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/beta-arbitrum/71Taxmh83WBsxeKyRbXQAr48agDG
✅ Preview: https://beta-arbitrum-git-evgeny-ui-724-update-bnc-sdk-9f17fd-balancer.vercel.app

arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/arbitrum/EV5KY2Lc4o1uegA7jdMisUjZz7s6
✅ Preview: https://arbitrum-git-evgeny-ui-724-update-bnc-sdk-to-su-bd4f0a-balancer.vercel.app

Network.RINKEBY,
Network.ROPSTEN,
Network.GÖRLI,
Network.POLYGON
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added the other Ethereum testnets along with Polygon

@garethfuller
Copy link
Collaborator

@evgenyboxer did we add any Polygon specific logic to compensate for not having blocknative that we should now remove?

@evgenyboxer
Copy link
Contributor Author

@garethfuller I've scanned the code and it doesn't seem we do anything special for Polygon (except hiding/disabling some features).

Blocknative is mostly used for balance refetching and since everything is going through useEthers - it has a check to not fetch balances since it's going to be fetched via Blocknative - so all good on Polygon side.

… into evgeny/ui-724-update-bnc-sdk-to-support-polygon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants