Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 1.12.13 #673

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Hotfix 1.12.13 #673

merged 2 commits into from
Aug 12, 2021

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Aug 12, 2021

Description

Using the consent schema prevents and data being reported in the Google Analytics dashboard. Instead, we have to use the old version of GA and pass client_storage: none in the google tag config.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/67zr1FQhN6JZdqk4tu76yMNwGQLn
✅ Preview: Canceled

app – ./

🔍 Inspect: https://vercel.com/balancer/app/7QMst7R1j9uS2wm4ePeK4d5accnG
✅ Preview: Canceled

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/DKuEovufcWYQ1kZoJwKbzqV4YVa9
✅ Preview: https://staging-app-git-hotfix-11213-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/4V9ozh4YYQx2wGdXF4PH6EvySPUj
✅ Preview: https://staging-kovan-app-git-hotfix-11213-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/HJ7VgfF1Xcd5grb4JyeomxaYZaAg
✅ Preview: https://gnosis-git-hotfix-11213-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/2LL5fHJ38fwwN4yshByZEXrJjkDA
✅ Preview: Canceled

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/EcVv9BoVG85YCB5BJTG1UzzhqTci
✅ Preview: https://beta-polygon-git-hotfix-11213-balancer.vercel.app

@garethfuller garethfuller merged commit 6d50fd1 into master Aug 12, 2021
@garethfuller garethfuller deleted the hotfix/1.12.13 branch August 12, 2021 15:40
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant