Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 1.12.6 #656

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Hotfix 1.12.6 #656

merged 2 commits into from
Aug 10, 2021

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Aug 10, 2021

Description

Fixes price fetching when no price information is available from coingecko. The registry refactor introduced a bug where by the prices map would return an empty object for a token it couldn't fetch the price for. Instead it shouldn't inject that token into the prices map at all.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Check warning is shown on this mainnet pool 0xea39581977325c0833694d51656316ef8a926a62000200000000000000000036

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/ERRRtPS8uAR7zJ3auYSsGa6otnGb
✅ Preview: Canceled

app – ./

🔍 Inspect: https://vercel.com/balancer/app/2pjmKxchkSRvtNkqm9QA8zbK1wgV
✅ Preview: Canceled

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/EsyqujGH5X2TRH71whnSpk8NBP4p
✅ Preview: https://staging-app-git-hotfix-1126-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/J9siEtf1n7ddgiHP3dDcWhMRWpKL
✅ Preview: https://staging-kovan-app-git-hotfix-1126-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/BCoEQ2ja1PZWVaRc5Hbc8wcnbmKx
✅ Preview: https://gnosis-git-hotfix-1126-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/GypSpJM4hAGgJT3j7Rh9jDXEgu8Z
✅ Preview: Canceled

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/2YMRescYnjq4AHuo1KCRTAVapwAK
✅ Preview: https://beta-polygon-git-hotfix-1126-balancer.vercel.app

@garethfuller garethfuller merged commit 2397ee0 into master Aug 10, 2021
@garethfuller garethfuller deleted the hotfix/1.12.6 branch August 10, 2021 20:21
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant