Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/1.12.5 #654

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Hotfix/1.12.5 #654

merged 2 commits into from
Aug 10, 2021

Conversation

arb000r
Copy link
Collaborator

@arb000r arb000r commented Aug 10, 2021

Description

Currently people are complaining about balancer rewards showing as 0. This is probably only on the polygon network. This issue happens because in the claim function it is filtering incentive thingos (its 2am) with the BAL token address for mainnet. I've added an extra key under AddressMap to make it refer explicitly to the network in question.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

Test affected features from files changed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@arb000r arb000r requested a review from garethfuller August 10, 2021 16:37
@arb000r arb000r changed the base branch from develop to master August 10, 2021 16:37
@vercel
Copy link

vercel bot commented Aug 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/BngfM9nTLKKQXptvYDqL9qRzRqH6
✅ Preview: Canceled

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/Ctcms37N9C5ssnx1dY2sjN73udbC
✅ Preview: https://gnosis-git-hotfix-1125-balancer.vercel.app

app – ./

🔍 Inspect: https://vercel.com/balancer/app/61yybkKRD6uiv1N9MKP65bXMGqmr
✅ Preview: Canceled

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/F4d2rbZGWfbktvgs2UbTMcCbReTh
✅ Preview: https://staging-kovan-app-git-hotfix-1125-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/9hTFm2frhGwH9NTfjx7WaeN5TT32
✅ Preview: Canceled

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/4R5twVbABBKuNzFEdZvv2bwAHrKG
✅ Preview: https://staging-app-git-hotfix-1125-balancer.vercel.app

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/9Ut7kPRq9uj1vfkoPSA19J8vVuN9
✅ Preview: https://beta-polygon-git-hotfix-1125-balancer.vercel.app

@garethfuller garethfuller merged commit bd873fc into master Aug 10, 2021
@garethfuller garethfuller deleted the hotfix/1.12.5 branch August 10, 2021 17:06
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants