Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/1.11.1 #608

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Hotfix/1.11.1 #608

merged 1 commit into from
Jul 29, 2021

Conversation

TomAFrench
Copy link
Contributor

Description

We're pulling all pooltypes from the subgraph however we don't currently support Element pools in the frontend. This results in them not displaying correctly and trying to click on one will kick you back to the homepage.

I've set the subgraph service to not return Element pools by default.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

  • Check that the main page pool's table is properly populated with Weighted and Stable pools

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/7aR4cbKkz2xJKaqqVuwrwRWVVKwx
✅ Preview: Canceled

[Deployment for a3b9a41 canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/AzHw2MfM8uf7PWiFVYXYrDP5KZK6
✅ Preview: Canceled

[Deployment for a3b9a41 canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/WGEs6FdpmaSiNLDAwNGe15qYK7kC
✅ Preview: https://staging-app-git-hide-element-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/2AGcs6xc7GrqthhLKKvtdsEwLGbA
✅ Preview: https://staging-kovan-app-git-hide-element-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/BV5NxgZmdRgXbVig65S6noA3ATHY
✅ Preview: https://gnosis-git-hide-element-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/8XTERhAXeKLQcSaubz8CVjfQ8hQf
✅ Preview: https://polygon-git-hide-element-balancer.vercel.app

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/FzdcX2CkCvZkWgNzA7p2jwFBHfCM
✅ Preview: https://beta-polygon-git-hide-element-balancer.vercel.app

@garethfuller
Copy link
Collaborator

garethfuller commented Jul 29, 2021

@TomAFrench Thanks for this! Could we make it a hotfix? i.e. branch off master, cherry-pick your changes on to that branch, bump the version npm version patch and then create a PR based on master.

@garethfuller garethfuller merged commit ca104c7 into master Jul 29, 2021
@garethfuller garethfuller deleted the hide-element branch July 29, 2021 13:19
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants