-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gnosis Safe connector #588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyboxer
approved these changes
Aug 10, 2021
evgenyboxer
reviewed
Aug 11, 2021
@garethfuller can you sign off on this? I can't merge without a rereview |
garethfuller
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry for the delay.
No worries, this got pushed down the priority list so I didn't even notice it was still locked until this morning. |
This was referenced Aug 24, 2021
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Gnosis Safe connector which allows loading the interface through the Gnosis website to directly connect to a Safe.
Type of change
How should this be tested?
The main issue which needs to be tested is that we correctly pick up when a transaction confirms when using a Gnosis safe with only one signer. This is because we don't talk directly with the RPC but through a Gnosis service which sometimes can not know about a transaction that's in flight for some time.
Testing that you can do a single transaction and not have the app get stuck in an infinite load should be sufficient but we should probably test each transaction type just to be thorough.
You can load the app on either mainnet or polygon
To open as a safe app:
If you're trying to run this on mainnet then you need to run the app locally as passwords on Vercel prevent it from loading properly
Known issues:
Transactions in the "recent activity" menu use the "safeTxHash" rather than the real hash so the links are broken.AddressedIt's possible to connect to metamask on the Gnosis interface so we should detect this case and prevent connecting to other wallets.AddressedChecklist:
master
if hotfix,develop
if not