Migrate composables to a provider pattern, so watchers and composables register once. #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arb000r
commented
Jul 8, 2021
Comment on lines
+4
to
+8
| import Provider from '@/plugins/providers/Provider.vue'; | ||
| import provideTokenStore from '@/plugins/providers/tokenstore.provider'; | ||
| import provideTokens from '@/plugins/providers/tokens.provider'; | ||
| import provideAccountBalances from '@/plugins/providers/balances.provider'; | ||
| import provideAccountAllowances from '@/plugins/providers/allowances.provider'; |
There was a problem hiding this comment.
These probably will move to a better home that isn't inside plugins
This was referenced Jul 21, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current issue with a lot of token list lag was the fact that our composables were called many times. Given the fact that these composable instances are isolated, they would register their own watchers and computed properties multiple times as well.
Some of of these watchers and composables are quite hefty in the compute they perform, so it would essentially become a very expensive render every tim.
This PR aims to refactor that logic and move the more used composable contents to a provider pattern, so they are provided once (watchers and computables) registered once and a much needed speed improvement is introduced.
Fixes #TokenListsLagging
Type of change
How should this be tested?
Entire app, make sure invest works, withdraw works (balances update when so). Trading works (balances update)
Checklist:
masterif hotfix,developif not