hotfix: Minor RPC init optimization (#4195)

* chore: Optimize provider initiation

* chore: We should only ever be instatiating the static provider

src/services/rpc-provider/rpc-provider.service.spec.ts

@@ -1,35 +1,23 @@
-import { JsonRpcProvider } from '@ethersproject/providers';
-
 import RpcProviderService from '@/services/rpc-provider/rpc-provider.service';
 import { StaticJsonRpcBatchProvider } from './static-json-rpc-batch-provider';
 
-vi.mock('@ethersproject/providers', () => {
+vi.mock('./static-json-rpc-batch-provider', () => {
   return {
-    JsonRpcProvider: vi.fn().mockImplementation(() => {
+    StaticJsonRpcBatchProvider: vi.fn().mockImplementation(() => {
       return {
         once: vi.fn(),
       };
     }),
   };
 });
 
-vi.mock('./static-json-rpc-batch-provider', () => {
-  return {
-    StaticJsonRpcBatchProvider: vi.fn().mockImplementation(() => {
-      return {};
-    }),
-  };
-});
-
 describe('RPC provider service', () => {
-  const MockedJsonRpcProvider = vi.mocked(JsonRpcProvider, true);
   const MockedStaticJsonRpcBatchProvider = vi.mocked(
     StaticJsonRpcBatchProvider,
     true
   );
 
   beforeEach(() => {
-    MockedJsonRpcProvider.mockClear();
     MockedStaticJsonRpcBatchProvider.mockClear();
   });
 
@@ -42,9 +30,4 @@ describe('RPC provider service', () => {
     new RpcProviderService();
     expect(MockedStaticJsonRpcBatchProvider).toHaveBeenCalledTimes(1);
   });
-
-  it('Calls the WebSocketProvider', () => {
-    new RpcProviderService().initBlockListener(() => ({}));
-    expect(MockedJsonRpcProvider).toHaveBeenCalledTimes(1);
-  });
 });

src/services/rpc-provider/rpc-provider.service.ts

@@ -15,8 +15,7 @@ export default class RpcProviderService {
   ) {}
 
   public initBlockListener(newBlockHandler: NewBlockHandler): void {
-    const blockProvider = new JsonRpcProvider(this.config.rpc);
-    blockProvider.once('block', newBlockNumber => {
+    this.jsonProvider.once('block', newBlockNumber => {
       let currentBlockNumber = newBlockNumber;
       newBlockHandler(currentBlockNumber);
       setInterval(() => {