Batch relayer chaining #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_STORAGE_SUFFIX Swapping the order meant that we were no longer replicating the standard mapping mechanism
TomAFrench
reviewed
Oct 27, 2021
|
This is still missing exits, but I think it can be merged as-is (after review) in the interest of keeping PRs small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #944
This adds initial support for batch relayer input-output chaining. Support for exits is still pending, as are some tests and documentation. There are a few repeated code structures (including test helpers), but I chose to not do anything too fancy as we're still missing a few complex use cases (including using the relayer's own balance as an input), so this seemed premature.
The PR itself is rather large, though this is mostly because of extensive tests. It can also be effectively be viewed in a commit-by-commit manner, where new features and their tests are progressively added.