Invoice spec #709
Open
Invoice spec #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge
Initial invoice spec. Once discussed, invoices feature will be added to this PR.
Requires the following back-end changes:
Remove
marketplace_uri
uri
settlement links
Rename
debits_count -> card_debits_count
debits_total_amount -> card_debits_total_amount
debits_total_fee -> card_debits_total_fee
hold_fee -> card_hold_fee
holds_count -> card_holds_count
holds_total_amount -> card_holds_total_amount
holds_total_fee -> card_holds_total_fee
state -> status
variable_fee_percentage -> card_debit_variable_fee_percentage
Change
state -> status values should be standardized to
pending,succeeded,failedperiod -> period_start, period_end