Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thevoting/proposals/ endpoint returns wrong status for proposal. #23

Closed
sras opened this issue Dec 1, 2020 · 1 comment
Closed

Thevoting/proposals/ endpoint returns wrong status for proposal. #23

sras opened this issue Dec 1, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@sras
Copy link

sras commented Dec 1, 2020

The Edo proposal is still in proposal phase, but its status is returned as skipped while using this endpoint. This is the response returned as of now.

{
  "hash": "PtEdoTezd3RHSC31mpxxo1npxFjoWWcFgQtxapi51Z8TLu6v6Uq",
  "initiator": {
    "alias": "Stakery",
    "address": "tz1go7f6mEQfT2xX2LuHAqgnRGN6c2zHPf5c"
  },
  "period": 37,
  "upvotes": 3331,
  "status": "skipped",
  "metadata": {
    "alias": "Edo",
    "agora": "https://www.tezosagora.org/proposal/9",
    "invoice": 0
  }
}
@sras sras changed the title Thevoting/proposals/ endpoint return wrong status for proposal. Thevoting/proposals/ endpoint returns wrong status for proposal. Dec 1, 2020
@Groxan Groxan added the bug Something isn't working label Dec 1, 2020
@Groxan
Copy link
Member

Groxan commented Dec 1, 2020

Thanks, will be fixed in the next release

Groxan added a commit that referenced this issue Dec 19, 2020
@Groxan Groxan closed this as completed in 9737135 Dec 21, 2020
ajinkyaraj-23 added a commit to ajinkyaraj-23/tzkt that referenced this issue Oct 7, 2024
* Add ShardsAttested and Attested (bool) field in DalCommitmentStatus

* update cumulative attestations received from all bakers for a Dal commitment

* Add API endpoints for cumulative DAL commitment status

* Use cache services for dalcommitmentstatus in UpdateDalCommitmentStatus

* Cache the dal attestation data for this level.

* Revert status update made to DalCommitmentStatus due to this block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants