Fix: 204 on unknown OPG

baking-bad · Mar 11, 2021 · f6f26f9 · f6f26f9
1 parent d7f4f46
commit f6f26f9
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/cmd/api/docs/docs.go b/cmd/api/docs/docs.go
@@ -1952,6 +1952,12 @@ var doc = `{
                             }
                         }
                     },
+                    "204": {
+                        "description": "No Content",
+                        "schema": {
+                            "$ref": "#/definitions/gin.H"
+                        }
+                    },
                     "400": {
                         "description": "Bad Request",
                         "schema": {

diff --git a/cmd/api/docs/swagger.json b/cmd/api/docs/swagger.json
@@ -1934,6 +1934,12 @@
                             }
                         }
                     },
+                    "204": {
+                        "description": "No Content",
+                        "schema": {
+                            "$ref": "#/definitions/gin.H"
+                        }
+                    },
                     "400": {
                         "description": "Bad Request",
                         "schema": {

diff --git a/cmd/api/docs/swagger.yaml b/cmd/api/docs/swagger.yaml
@@ -2636,6 +2636,10 @@ paths:
             items:
               $ref: '#/definitions/handlers.Operation'
             type: array
+        "204":
+          description: No Content
+          schema:
+            $ref: '#/definitions/gin.H'
         "400":
           description: Bad Request
           schema:

diff --git a/cmd/api/handlers/operations.go b/cmd/api/handlers/operations.go
@@ -79,6 +79,7 @@ func (ctx *Context) GetContractOperations(c *gin.Context) {
 // @Accept  json
 // @Produce  json
 // @Success 200 {array} Operation
+// @Success 204 {object} gin.H
 // @Failure 400 {object} Error
 // @Failure 500 {object} Error
 // @Router /v1/opg/{hash} [get]
@@ -114,6 +115,11 @@ func (ctx *Context) GetOperation(c *gin.Context) {
 			}
 		}
 
+		if len(op) == 0 {
+			c.JSON(http.StatusNoContent, gin.H{})
+			return
+		}
+
 		c.JSON(http.StatusOK, opg)
 		return
 	}