Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics Fixes #368

Merged
merged 14 commits into from
Apr 23, 2022
Merged

Analytics Fixes #368

merged 14 commits into from
Apr 23, 2022

Conversation

ungarson
Copy link
Contributor

No description provided.

@ungarson ungarson changed the title Analytics Fixes WIP: Analytics Fixes Apr 18, 2022
@ungarson ungarson requested a review from m-kus April 18, 2022 09:58
@ungarson ungarson self-assigned this Apr 18, 2022
@ungarson
Copy link
Contributor Author

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 18, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86a5898
Status: ✅  Deploy successful!
Preview URL: https://6d4262a5.bcd.pages.dev

View logs

@ungarson
Copy link
Contributor Author

@ungarson ungarson changed the title WIP: Analytics Fixes Analytics Fixes Apr 18, 2022
@ungarson
Copy link
Contributor Author

@@ -253,9 +255,9 @@ export default {

addHistoryItem(this.buildHistoryItem(this.model, value || this.searchText));
if (this.isModelsArrayInclude("operation") && checkOperation(value)) {
this.pushTo(`/${network}/opg/${value}`);
this.pushTo(`/${network}/opg/${value}`, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushTo(path) no longer has second arg right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-kus thnx fixed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@m-kus m-kus merged commit 134012c into master Apr 23, 2022
@m-kus m-kus deleted the fix/sc-collect-fixes branch April 23, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants