Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rules available as a plugin fixes #4 #6

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

ericwooley
Copy link
Contributor

Fixes #4

@ericwooley
Copy link
Contributor Author

I'm having a hard time figuring out your unit tests, it says Error: Cannot find module 'collections/shim', not sure what the deal is, but I only added an index file and change the package.json info.

bahmutov added a commit that referenced this pull request Dec 8, 2015
Make rules available as a plugin fixes #4
@bahmutov bahmutov merged commit f2289e2 into bahmutov:master Dec 8, 2015
@bahmutov
Copy link
Owner

bahmutov commented Dec 8, 2015

published as 0.6.0

@ericwooley
Copy link
Contributor Author

Awesome, thanks!

@mattdell
Copy link

This thread was a very useful guide for how to use this in my project. Could we update the readme to include the steps...

  • Add 'extra-rules' to plugins in .eslintrc
  • Prefix rules with extra-rules (i.e. - extra-rules/no-commented-out-code: 2)

@bahmutov ?

@bahmutov
Copy link
Owner

@mattdell sure, but maybe you could make the changes and add a pull request? I promise to merge it ASAP

Wilfred added a commit to Wilfred/eslint-rules that referenced this pull request May 30, 2017
As discussed in bahmutov#6, it's useful to have an example to help new users.

This removes the "running" section which is no longer necessary
now that bahmutov#4 is fixed.

It also groups the rules under a separate heading in the README.
Wilfred added a commit to Wilfred/eslint-rules that referenced this pull request May 30, 2017
As discussed in bahmutov#6, it's useful to have an example to help new users.

This removes the "running" section which is no longer necessary
now that bahmutov#4 is fixed.

It also groups the rules under a separate heading in the README.
@Wilfred Wilfred mentioned this pull request May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants