Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Double tap handler to BaseMessageCollectionViewCell & MessageInteractionHandler #692

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

wiruzx
Copy link
Contributor

@wiruzx wiruzx commented Jan 25, 2021

This is a copy of #691:

  1. Added new gesture recogniser to BaseMessageCollectionViewCell, a bit updated delegate methods to work simultaneously with others.
  2. Updated BaseMessageInteractionHandlerProtocol to have double-tap handler method.
  3. BaseMessagePresenter translates new gesture event to interaction handler.
  4. Unit-test for BaseMessagePresenter added.

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #692 (0c106a6) into master (79f9e40) will increase coverage by 0.24%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   58.23%   58.47%   +0.24%     
==========================================
  Files          99       99              
  Lines        5138     5154      +16     
==========================================
+ Hits         2992     3014      +22     
+ Misses       2146     2140       -6     
Impacted Files Coverage Δ
...eMessage/Views/BaseMessageCollectionViewCell.swift 58.19% <91.66%> (+1.29%) ⬆️
.../Chat Items/BaseMessage/BaseMessagePresenter.swift 63.63% <100.00%> (+1.73%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 85.71% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f9e40...0c106a6. Read the comment docs.

@wiruzx wiruzx merged commit 85c7087 into master Jan 27, 2021
@wiruzx wiruzx deleted the AKoulabukhov-message-double-tap-support branch January 27, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants