Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight message #670

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Highlight message #670

merged 5 commits into from
Sep 9, 2020

Conversation

wiruzx
Copy link
Contributor

@wiruzx wiruzx commented Sep 6, 2020

This pull requests adds ability to spotlight the message when using scrollToItem method on BaseChatViewController

For compound messages it's supported out of the box. It'll tint background color of CompoundBubbleView.
If you'd like to support other presenters, override spotlight method in your presenter.

You can specify which color to use for tinting background of CompoundBubbleView in DefaultCompoundBubbleViewStyle.
By default we're reducing brightness of background color by 15%.

You can also change how long bubble is going to be spotlighted in DefaultCompoundBubbleViewStyle.
Default value is 0.5 seconds.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2020

Codecov Report

Merging #670 into master will decrease coverage by 55.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #670       +/-   ##
===========================================
- Coverage   73.38%   18.04%   -55.34%     
===========================================
  Files          19       97       +78     
  Lines        1236     5027     +3791     
===========================================
  Hits          907      907               
- Misses        329     4120     +3791     
Impacted Files Coverage Δ
...atto/Source/Chat Items/BaseChatItemPresenter.swift 50.00% <0.00%> (-1.03%) ⬇️
...ource/Chat Items/ChatItemProtocolDefinitions.swift 42.85% <0.00%> (-7.15%) ⬇️
...tController/BaseChatViewController+Scrolling.swift 55.55% <0.00%> (-8.28%) ⬇️
...ems/CompoundMessage/CompoundMessagePresenter.swift 0.00% <0.00%> (ø)
...ems/CompoundMessage/Views/CompoundBubbleView.swift 0.00% <0.00%> (ø)
...ompoundMessage/Views/CompoundBubbleViewStyle.swift 0.00% <0.00%> (ø)
...poundMessage/CompoundMessagePresenterBuilder.swift 0.00% <0.00%> (ø)
...ditions/Source/Common/UIEdgeInsets+Additions.swift 0.00% <0.00%> (ø)
...rcleProgressIndicatorView/CircleProgressView.swift 0.00% <0.00%> (ø)
...attoAdditions/Source/Common/UIView+Additions.swift 0.00% <0.00%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d465a14...d89dac0. Read the comment docs.

@wiruzx wiruzx merged commit 8ab0d7b into master Sep 9, 2020
@wiruzx wiruzx deleted the highlight-message branch September 9, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants