Add safe area insets for decoration views #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wiruzx
commented
Jul 29, 2020
wiruzx
commented
- Decoration views now have ability to change safe area, so content could adjust accordingly
- Layout for text messages is now done via layout provider instead of passing textInsets
| self.tailWidth = tailWidth | ||
| self.isIncoming = isIncoming | ||
| } | ||
|
|
||
| public func hash(into hasher: inout Hasher) { | ||
| hasher.combine(self.layoutProviders.map { $0.asHashable }) | ||
| hasher.combine(self.layoutProviders.map(\.asHashable)) | ||
| hasher.combine(self.layoutProviders.map(\.asHashable)) |
wiruzx
force-pushed
the
decoration-safe-area-insets
branch
from
1795cdb to
5836ce0
Compare
wiruzx
force-pushed
the
decoration-safe-area-insets
branch
from
5836ce0 to
24d1c95
Compare
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 19 19
Lines 1236 1236
=======================================
Hits 907 907
Misses 329 329 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.