Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made overridden inputAccessoryView read-write #644

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

wiruzx
Copy link
Contributor

@wiruzx wiruzx commented Feb 26, 2020

From #643

@dive
Copy link
Member

dive commented Mar 18, 2020

@wiruzx, @azatZul, let's merge it? This is how it suppose to be anyway.

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #644 into master will increase coverage by 11.71%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #644       +/-   ##
===========================================
+ Coverage   61.13%   72.84%   +11.71%     
===========================================
  Files          92       19       -73     
  Lines        4953     1197     -3756     
===========================================
- Hits         3028      872     -2156     
+ Misses       1925      325     -1600
Impacted Files Coverage Δ
...ler/Collaborators/BaseChatViewControllerView.swift 0% <0%> (ø) ⬆️
...Controller/BaseChatViewController+Presenters.swift 61.76% <0%> (-1.62%) ⬇️
...Source/ChatController/BaseChatViewController.swift 69.25% <0%> (-1.28%) ⬇️
...oller/Collaborators/ChatCollectionViewLayout.swift 85.05% <0%> (-1.12%) ⬇️
...hatController/BaseChatViewController+Changes.swift 88.51% <0%> (-0.43%) ⬇️
...atController/Collaborators/CollectionChanges.swift 100% <0%> (ø) ⬆️
...otos/PhotosInputWithPlaceholdersDataProvider.swift
ChattoAdditions/Source/Input/TabInputButton.swift
...s/CircleProgressIndicatorView/CircleIconView.swift
...s/PhotoMessageCollectionViewCellDefaultStyle.swift
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f0951...b40adb5. Read the comment docs.

@wiruzx wiruzx merged commit 8bbae84 into master Mar 19, 2020
@wiruzx wiruzx deleted the input_accessory_view_field_fix branch March 19, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants