Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable module stability support #625

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Conversation

dive
Copy link
Member

@dive dive commented Nov 7, 2019

In order to support module stability feature, I switched Chatto & ChattoAdditions to Swift 5 source compatibility mode and enabled BUILD_LIBRARY_FOR_DISTRIBUTION option for release configurations.
There are no logical changes, also, I did not touch some generic warnings.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #625 into master will decrease coverage by 0.03%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   60.73%   60.69%   -0.04%     
==========================================
  Files          92       92              
  Lines        4892     4898       +6     
==========================================
+ Hits         2971     2973       +2     
- Misses       1921     1925       +4
Impacted Files Coverage Δ
...BaseChatViewController+AccessoryViewRevealer.swift 0% <ø> (ø) ⬆️
.../Chat Items/BaseMessage/BaseMessageViewModel.swift 89.65% <100%> (ø) ⬆️
ChattoAdditions/Source/Common/AnimationUtils.swift 100% <100%> (ø) ⬆️
...ws/BaseMessageCollectionViewCellDefaultStyle.swift 96.47% <100%> (ø) ⬆️
...ditions/Source/Common/UIEdgeInsets+Additions.swift 100% <100%> (ø) ⬆️
...s/PhotoMessageCollectionViewCellDefaultStyle.swift 84.09% <100%> (ø) ⬆️
...ttoAdditions/Source/Common/UIColor+Additions.swift 100% <100%> (ø) ⬆️
...ws/TextMessageCollectionViewCellDefaultStyle.swift 91.78% <100%> (ø) ⬆️
.../Input/Photos/Camera/LiveCameraCellPresenter.swift 80.41% <33.33%> (-1.51%) ⬇️
...ttoAdditions/Source/Common/UIImage+Additions.swift 30.3% <33.33%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb0868...3ca6ff7. Read the comment docs.

@MikhailGasanov MikhailGasanov merged commit 25cf300 into master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants