Input bar relayouting #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utContainerBottomBaseOffset and inputContainerBottomAdditionalOffset
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 60.59% 60.76% +0.17%
==========================================
Files 92 92
Lines 4875 4881 +6
==========================================
+ Hits 2954 2966 +12
+ Misses 1921 1915 -6
Continue to review full report at Codecov.
|
wiruzx
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputContainerBottomConstraint.constant should always depend on both self.bottomLayoutGuide.length and an additional offset managed by a keyboard tracker. In this pull-request, I've extracted this logic into a updateInputContainerBottomConstraint() method to fix an issue when updates from the keyboard tracker could break a proper input bar position if the bottom layout guide wasn't taken into account.