-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compound bubble updates #587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
turbulem
commented
Jul 5, 2019
•
edited
Loading
edited
- Now insets and spacing for compound bubble components are defined on the bubble level, as opposed to the previous method when each bubble could define it's own insets.
- Added new struct for providing new configuration CompoundBubbleLayoutProvider.Dimensions
- Make bubble components fill all bubble width after determining it's size (by the widest component)
- Additional option for MessageManualLayoutProviderProtocol to ignore content insets within the bubble (so component fill all available width minus safe insets)
…o provide desired layout strategy. First two options are default (leading) and new fill. When content alignment is fill, all views are stretched to fill the whole bubble width
…otocol to provide desired layout strategy. First two options are default (leading) and new fill. When content alignment is fill, all views are stretched to fill the whole bubble width" This reverts commit 65e3b38.
…onent to fill all available width. Add new config struct for compound bubble layout dimensions
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 58.44% 58.07% -0.37%
==========================================
Files 90 90
Lines 3824 3843 +19
==========================================
- Hits 2235 2232 -3
- Misses 1589 1611 +22
Continue to review full report at Codecov.
|
…o compound_bubble_updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.