Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound bubble updates #587

Merged
merged 12 commits into from
Jul 9, 2019
Merged

Compound bubble updates #587

merged 12 commits into from
Jul 9, 2019

Conversation

turbulem
Copy link
Contributor

@turbulem turbulem commented Jul 5, 2019

  • Now insets and spacing for compound bubble components are defined on the bubble level, as opposed to the previous method when each bubble could define it's own insets.
  • Added new struct for providing new configuration CompoundBubbleLayoutProvider.Dimensions
  • Make bubble components fill all bubble width after determining it's size (by the widest component)
  • Additional option for MessageManualLayoutProviderProtocol to ignore content insets within the bubble (so component fill all available width minus safe insets)

Serhii Zabrodko and others added 7 commits July 4, 2019 15:02
…o provide desired layout strategy. First two options are default (leading) and new fill. When content alignment is fill, all views are stretched to fill the whole bubble width
…otocol to provide desired layout strategy. First two options are default (leading) and new fill. When content alignment is fill, all views are stretched to fill the whole bubble width"

This reverts commit 65e3b38.
…onent to fill all available width. Add new config struct for compound bubble layout dimensions
@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #587 into master will decrease coverage by 0.36%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   58.44%   58.07%   -0.37%     
==========================================
  Files          90       90              
  Lines        3824     3843      +19     
==========================================
- Hits         2235     2232       -3     
- Misses       1589     1611      +22
Impacted Files Coverage Δ
...dMessage/Content/MessageManualLayoutProvider.swift 0% <ø> (ø) ⬆️
...ems/CompoundMessage/CompoundMessagePresenter.swift 0% <0%> (ø) ⬆️
...poundMessage/CompoundMessagePresenterBuilder.swift 0% <0%> (ø) ⬆️
...s/CompoundMessage/Views/CompoundBubbleLayout.swift 0% <0%> (ø) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 78.88% <0%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8f4ba...0120568. Read the comment docs.

@turbulem turbulem merged commit 0530118 into master Jul 9, 2019
@turbulem turbulem deleted the compound_bubble_updates branch July 9, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants