Compound bubble approach for text messages #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=========================================
- Coverage 59.76% 58.6% -1.17%
=========================================
Files 88 90 +2
Lines 3731 3805 +74
=========================================
Hits 2230 2230
- Misses 1501 1575 +74
Continue to review full report at Codecov.
|
wiruzx
requested changes
May 29, 2019
ChattoAdditions/Source/Chat Items/CompoundMessage/Content/MessageContentFactoryProtocol.swift
Outdated
Show resolved
Hide resolved
…y CompoundMessagePresenter
wiruzx
previously requested changes
Jun 19, 2019
ChattoAdditions/Source/Chat Items/CompoundMessage/CompoundMessagePresenter.swift
Outdated
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/CompoundMessagePresenter.swift
Outdated
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/Content/MessageContentFactoryProtocol.swift
Outdated
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/Content/MessageContentFactoryProtocol.swift
Outdated
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/Content/MessageContentFactoryProtocol.swift
Outdated
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/Views/CompoundBubbleView.swift
Outdated
Show resolved
Hide resolved
…ndBubbleView.swift Co-Authored-By: Victor Shamanov <[email protected]>
|
Looks good to me |
AntonPalich
reviewed
Jun 25, 2019
ChattoAdditions/Source/Chat Items/CompoundMessage/CompoundMessagePresenter.swift
Show resolved
Hide resolved
ChattoAdditions/Source/Chat Items/CompoundMessage/CompoundMessagePresenter.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.