Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a presenter factory is postponed until it's needed for it… #528

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

MikhailGasanov
Copy link
Contributor

…em presenters

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #528 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #528      +/-   ##
=========================================
+ Coverage   64.65%   64.7%   +0.04%     
=========================================
  Files          76      76              
  Lines        3919    3924       +5     
=========================================
+ Hits         2534    2539       +5     
  Misses       1385    1385
Impacted Files Coverage Δ
...hatController/BaseChatViewController+Changes.swift 86.25% <ø> (-0.23%) ⬇️
...Controller/BaseChatViewController+Presenters.swift 48.52% <100%> (+4.08%) ⬆️
...Source/ChatController/BaseChatViewController.swift 76.31% <100%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa67bac...7cbac82. Read the comment docs.

@AntonPalich AntonPalich merged commit 6c33413 into master Nov 7, 2018
@AntonPalich AntonPalich deleted the lazy_initialization_of_builders branch November 7, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants